Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register GRPC message service #328

Closed
alpe opened this issue Dec 2, 2020 · 1 comment · Fixed by #366
Closed

Register GRPC message service #328

alpe opened this issue Dec 2, 2020 · 1 comment · Fixed by #366
Assignees
Labels
enhancement New feature or request extension point Makes the system easier to extend or test

Comments

@alpe
Copy link
Contributor

alpe commented Dec 2, 2020

We support the GRPC query handler but there is also a message handler implementation in other modules like:

// RegisterServices registers module services.
func (am AppModule) RegisterServices(cfg module.Configurator) {
	types.RegisterMsgServer(cfg.MsgServer(), keeper.NewMsgServerImpl(am.keeper))
	querier := keeper.Querier{Keeper: am.keeper}
	types.RegisterQueryServer(cfg.QueryServer(), querier)
}

@alpe alpe added this to the v1.0.0 milestone Dec 2, 2020
@ethanfrey
Copy link
Member

Yeah, that was a new technique that started with rc2 or so.. I think this was defined in ADR 31 or 29?

@alpe alpe added enhancement New feature or request extension point Makes the system easier to extend or test labels Dec 14, 2020
@alpe alpe self-assigned this Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request extension point Makes the system easier to extend or test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants