Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charge gas for contract KV store keys #333

Closed
alpe opened this issue Dec 4, 2020 · 4 comments
Closed

Charge gas for contract KV store keys #333

alpe opened this issue Dec 4, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@alpe
Copy link
Contributor

alpe commented Dec 4, 2020

Currently only the stored value is charged. With other cosmos modules the keys are build in Go and user input can not influence them very much but with our Wasm contracts the keys could be easily used for payload to bypass the gas metering. 🤪

@ethanfrey
Copy link
Member

This is done in CosmWasm main, and I think will be back ported to 0.44.

Can we just rely on that and make a note about it somewhere (that people can back port PR x if they need it, otherwise available in next wasmd version)?

@ethanfrey ethanfrey modified the milestones: v1.0.0, v2.0.0 Oct 7, 2021
@ethanfrey
Copy link
Member

This will be done in v2, when we upgrade to cosmos-sdk 0.44

@alpe
Copy link
Contributor Author

alpe commented Oct 8, 2021

Link for the sdk upgrade: #501

@ethanfrey
Copy link
Member

This is in Cosmos SDK 0.45 and on master!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants