Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events/ event attributes on reply #552

Closed
alpe opened this issue Jul 5, 2021 · 2 comments
Closed

Events/ event attributes on reply #552

alpe opened this issue Jul 5, 2021 · 2 comments
Assignees
Labels
Milestone

Comments

@alpe
Copy link
Contributor

alpe commented Jul 5, 2021

Currently we append them as new custom events or wasm event (with attributes).
This means there can be duplicate events for wasm or custom event types. Not sure if this is (still) an issue for Tendermint.

I would also be important to document the desired behaviour in cosmwasm. On Reply the data would be overwritten but events/attributes are not.

@alpe alpe added this to the v0.18.0 milestone Jul 5, 2021
@alpe alpe mentioned this issue Jul 5, 2021
10 tasks
@ethanfrey
Copy link
Member

This definitely needs documentation. The whole events system does.

Tendermint does still have this issue... It will improve in 0.35, see comment and tendermint/tendermint#6634

It would also be good to write some tests to demonstrate expected behavior as those seem to stay up-to-date much better than docs. (And are always more clear)

@ethanfrey
Copy link
Member

Defined in #581
Closed by #586

We will have multiple wasm events, but separated by the various entry point events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants