Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom client codec crashes with Rosetta enabled #749

Closed
alpe opened this issue Feb 9, 2022 · 3 comments · Fixed by #760
Closed

Custom client codec crashes with Rosetta enabled #749

alpe opened this issue Feb 9, 2022 · 3 comments · Fixed by #760
Assignees
Labels
bug Something isn't working
Milestone

Comments

@alpe
Copy link
Contributor

alpe commented Feb 9, 2022

We use a custom client codec to not print empty elements. This unfortunately does not work with the current sdk (v0.45.1 + current master) and creates:

panic: interface conversion: codec.Codec is *codec.ProtoCodec, not *codec.ProtoCodec (types from different packages)

Root cause for this panic is the type cast in the sdk

@alpe alpe added the bug Something isn't working label Feb 9, 2022
@alpe alpe added this to the v0.24.0 milestone Feb 9, 2022
@ethanfrey
Copy link
Member

So, we just use the standard codec?
Does this break anything?

@alpe
Copy link
Contributor Author

alpe commented Feb 16, 2022

Standard codec would be the quickest solution. On the downside, we end up with empty fields in genesis and cli json outputs.
I was thinking to open an issue with the sdk to address the cast, which should not be there IMHO but their workload is high already and we can solve this completely with standard codec.

@ethanfrey
Copy link
Member

I think the first solution to use standard codec is better. It only seems to have cosmetic issues.

I would support an upstream PR on Cosmos SDK to support custom codecs, or even make this "non-empty field" codec the default. But that would have to come from us and not wait for their work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants