Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused flag in gov proposals #849

Closed
jhernandezb opened this issue May 9, 2022 · 2 comments · Fixed by #968
Closed

Remove unused flag in gov proposals #849

jhernandezb opened this issue May 9, 2022 · 2 comments · Fixed by #968
Milestone

Comments

@jhernandezb
Copy link
Contributor

jhernandezb commented May 9, 2022

flagProposalType is being set in all gov proposals but only used in the sdk for the main submit-proposal command https://github.com/cosmos/cosmos-sdk/blob/v0.45.4/x/gov/client/cli/parse.go#L13

We should consider removing it if it's not actually used.

Context: #796 (comment)

@alpe
Copy link
Member

alpe commented May 12, 2022

I remember that this was used when reading a json file for the gov proposal, once. But this may not be the case anymore 🤷

@ethanfrey
Copy link
Member

Adding it to v0.28.0.

If this is possible without breaking the json import, let's do it. If not, let's just leave it as is (and close as "wont fix")

@ethanfrey ethanfrey added this to the v0.28.0 milestone Jun 17, 2022
@alpe alpe closed this as completed in #968 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants