Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve contract history/ created date on genesis import #878

Closed
alpe opened this issue May 31, 2022 · 3 comments · Fixed by #1076
Closed

Preserve contract history/ created date on genesis import #878

alpe opened this issue May 31, 2022 · 3 comments · Fixed by #1076
Assignees
Labels
L Estimated large
Milestone

Comments

@alpe
Copy link
Contributor

alpe commented May 31, 2022

For history reasons with Tendermint starting at height 0 only, we had squashed the contract history on dump state import. This is not needed anymore as Tendermint evolved and leaves some smell with tests using imports.

Preserving the full history and state would also enable adding more data to queries as requested feature.

@ethanfrey ethanfrey added this to the v1.0.0 milestone Jun 17, 2022
@alpe alpe moved this to 🆕 New in wasmd backlog Sep 23, 2022
@alpe alpe moved this from 🆕 New to 🏄 v0.30 stretch goal in wasmd backlog Sep 28, 2022
@alpe alpe modified the milestones: v1.0.0, v0.30.0 Oct 7, 2022
@alpe
Copy link
Contributor Author

alpe commented Nov 1, 2022

@GNaD13 is this something you find interesting and want to start?

@GNaD13
Copy link
Contributor

GNaD13 commented Nov 1, 2022

@GNaD13 is this something you find interesting and want to start?

Yeah, Can I take this??

@ethanfrey
Copy link
Member

I would remove this from 0.30 scope as it is L and already way over delivery.
But happy to merge this in main and the next release from when it is ready.

So, help is appreciated, but ideally we can check https://github.com/CosmWasm/wasmd/milestone/22 and ensure everything is done there first (some issues have open PRs already)

@ethanfrey ethanfrey modified the milestones: v0.30.0, v0.31.0 Nov 4, 2022
Repository owner moved this from 🏄 v0.30 stretch goal to ✅ Done in wasmd backlog Nov 11, 2022
@alpe alpe removed this from wasmd backlog Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L Estimated large
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants