Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add genesis tests #23

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Add genesis tests #23

merged 1 commit into from
Jan 14, 2020

Conversation

sunnya97
Copy link
Contributor

@sunnya97 sunnya97 commented Jan 13, 2020 •
edited
Loading

closes #20

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@sunnya97 sunnya97 requested a review from ethanfrey as a code owner January 13, 2020 20:33
@sunnya97 sunnya97 mentioned this pull request Jan 13, 2020
Merged
5 tasks
ethanfrey
ethanfrey approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the testcase, it looks good.

x/wasm/genesis_test.go
// export into genstate
genState := ExportGenesis(data.ctx, data.keeper)

// create new app to import genstate into
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a good way to create a new app.
Nice code reuse.

@ethanfrey ethanfrey merged commit eb78f8c into CosmWasm:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests for genesis functions
2 participants
@sunnya97 @ethanfrey