Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow streamy access to attachments #662

Closed
lowjoel opened this issue Dec 12, 2015 · 3 comments
Closed

Allow streamy access to attachments #662

lowjoel opened this issue Dec 12, 2015 · 3 comments
Labels

Comments

@lowjoel
Copy link
Member

lowjoel commented Dec 12, 2015

Currently CarrierWave only allows us to read an entire file into memory if we want to be backend agnostic. This is not possible for large attachments.

Tagged security because file uploads can be big, and can cause DoS.

@lowjoel
Copy link
Member Author

lowjoel commented Dec 12, 2015

@allenwq can add your findings here.

@cysjonathan
Copy link
Contributor

large file is going to blow memory carrierwaveuploader/carrierwave#1780
Fix CarrierWave reads large files into memory carrierwaveuploader/carrierwave#2314
Should be fixed in CarrierWave >= 1.2.3

@zhuhanming
Copy link
Member

In that case, this should be fixed, as the current version of carrierwave is 2.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants