Skip to content

Commit

Permalink
feat: bump typescript, use default type parameter (#1)
Browse files Browse the repository at this point in the history
* feat: bump typescript, use default type parameter

* feat: add default type param
  • Loading branch information
bsouthga authored Sep 6, 2017
1 parent 1abd6bd commit c1c2fca
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"semantic-release": "^6.3.6",
"tslint": "^5.0.0",
"tslint-config-prettier": "^1.1.0",
"typescript": "^2.0.0",
"typescript": "^2.5.2",
"validate-commit-msg": "^2.12.2"
},
"engines": {
Expand Down
4 changes: 2 additions & 2 deletions src/core/trackedEvent.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
* }
* @see {@link https://segment.com/docs/spec/track/#event}
*/
export abstract class TrackedEvent<T> {
export abstract class TrackedEvent<T = {}> {
/**
* We suggest human readable names consisting of noun + past tense verb.
* @see {@link https://segment.com/academy/collecting-data/naming-conventions-for-clean-data/}
Expand All @@ -30,7 +30,7 @@ export abstract class TrackedEvent<T> {

/**
* Many trackers only support a limited number of arguments. For example,
* Google Analytics only supports 2: a string Event Label and an integer
* Google Analytics only supports 2: a string Event Label and an integer
* Event Value. By defining a priority to your arguments here, trackers
* will submit the highest priority args satisfying their constraints. In
* the Google Analytics case, the tracker will submit the first string match
Expand Down
2 changes: 1 addition & 1 deletion src/core/value.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export type Value = string | number;
export type Value = string | number;
6 changes: 3 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4281,9 +4281,9 @@ typedarray@^0.0.6:
version "0.0.6"
resolved "https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"

typescript@^2.0.0:
version "2.4.1"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-2.4.1.tgz#c3ccb16ddaa0b2314de031e7e6fee89e5ba346bc"
typescript@^2.5.2:
version "2.5.2"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-2.5.2.tgz#038a95f7d9bbb420b1bf35ba31d4c5c1dd3ffe34"

uglify-js@^2.6:
version "2.8.29"
Expand Down

0 comments on commit c1c2fca

Please sign in to comment.