Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for postgres_exporter 13.0+ #347

Closed
szelenka opened this issue Jun 22, 2023 · 2 comments
Closed

Add support for postgres_exporter 13.0+ #347

szelenka opened this issue Jun 22, 2023 · 2 comments
Assignees
Labels
VALID Valid issue. Will be assigned and worked

Comments

@szelenka
Copy link

Describe the enhancement you are proposing:
Consume the latest version from upstream for newest features and security patches. The upstream postgres_exporter introduced breaking changes, specifically to how queries.yaml is handled:
https://github.com/prometheus-community/postgres_exporter/releases/tag/v0.13.0

Specifically these PRs:
prometheus-community/postgres_exporter#801
prometheus-community/postgres_exporter#811

This breaks the way CrunchyData/pgmonitor handles the dynamic generation of queries to export data to Prometheus in the CrunchData/pgmonitor/postgres_exporter folder.

The above PRs appear to be taking a strong-arm approach to force contributions to the upstream prometheus-community/postgres_exporter repo, rather than maintaining individual queries.yaml files.

To keep using the prometheus-community/postgres_exporter upstream, it seems this project will need to contribute back the changes to upstream.

@szelenka szelenka added the UNCONFIRMED Initial state. Need's triaged label Jun 22, 2023
@szelenka szelenka changed the title Add support for prometheus_exporter 13.0+ Add support for postgres_exporter 13.0+ Jun 22, 2023
@keithf4
Copy link
Collaborator

keithf4 commented Jun 22, 2023

Yes we are tracking this and will find a solution for this project. For now, you can continue using a version of the postgres_exporter that supports the custom query file feature.

@keithf4 keithf4 added VALID Valid issue. Will be assigned and worked and removed UNCONFIRMED Initial state. Need's triaged labels Jun 22, 2023
@keithf4
Copy link
Collaborator

keithf4 commented Feb 13, 2024

We will be migrating to using the sql_exporter in the future to solve this issue - #395

@keithf4 keithf4 self-assigned this Feb 13, 2024
@keithf4 keithf4 closed this as completed Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VALID Valid issue. Will be assigned and worked
Projects
None yet
Development

No branches or pull requests

2 participants