Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValueSetRef evaluator logic is incorrect #896

Closed
brynrhodes opened this issue Dec 22, 2021 · 1 comment
Closed

ValueSetRef evaluator logic is incorrect #896

brynrhodes opened this issue Dec 22, 2021 · 1 comment
Assignees
@brynrhodes
Labels
bug

Comments

@brynrhodes
Copy link
Member

Current implementation of the ValueSetRef node returns a ValueSetDef, which subsequently results in errors because the engine doesn't know what a ValueSetDef is:

https://github.com/DBCG/cql_engine/blob/master/engine/src/main/java/org/opencds/cqf/cql/engine/elm/execution/ValueSetRefEvaluator.java#L9

The implementation should be using the terminology provider to expand the ValueSet and return the list of codes.
@brynrhodes brynrhodes added the bug label Dec 22, 2021
@brynrhodes brynrhodes self-assigned this Dec 22, 2021
brynrhodes referenced this issue in cqframework/cql-engine Dec 30, 2021
@brynrhodes
#523: Fixed several issues related to supporting the new terminology …
3dace88 
…types in CQL 1.5:

1. Added runtime types to represent the new terminology types (`Vocabulary`, `CodeSystem`, and `ValueSet`), rather than the `Def` elements that were being used
2. Added support for the `ExpandValueSet` operator to explicitly expand a `ValueSet`
3. Updated the `ValueSetRef` implementation to expand the valueset if the `preserve` attribute is not present or set to false, and to return an instance of a `ValueSet` otherwise
4. Updated the `CodeSystemRef` implementation to return an instance of a `CodeSystem`
5. Updated the terminology membership implementations to use the new `Expression` elements only if they are present, and continue to use the `Ref` elements directly otherwise
6. Updated the engine to use the new runtime representations of terminology types throughout

For a more detailed discussion, see https://github.com/cqframework/CQL-Formatting-and-Usage-Wiki/wiki/Implementing-the-CQL-1.5-Terminology-Types
JPercival referenced this issue in cqframework/cql-engine Dec 30, 2021
@JPercival
Merge pull request #525 from DBCG/fix-523-terminology-type-support
c7ff2b0 
#523: Fixed several issues related to supporting the new terminology …
@JPercival
Copy link
Contributor

Resolved by cqframework/cql-engine#525

@JPercival JPercival transferred this issue from cqframework/cql-engine Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brynrhodes brynrhodes

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brynrhodes @JPercival