-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typer 0.12.4
is creating issues in DIRAC
/diracx
/diracx-web
CI pipelines
#280
Comments
This is seen of course also in diracx: https://github.com/DIRACGrid/diracx/actions/runs/10490376700/job/29056968669?pr=281 We can freeze the version in the |
I created a minimal reproducer and created an issue here: fastapi/typer#943. In the meantime, as you said, may be the easiest solution would be to freeze the version in |
In #281 I fixed |
Unfortunately, Setting upper bound can turn into a nightmare (https://iscinumpy.dev/post/bound-version-constraints/) and fixed version is unmanageable, so we ended up with this idea of letting the test always run the latest and fail, while production version are pinned https://github.com/DIRACGrid/diracx/blob/main/docs/TESTING.md and https://github.com/DIRACGrid/diracx/blob/main/docs/VERSIONING.md for details |
Here is the issue:
I have been able to reproduce the issue by downloading the latest
dirac-client
image:And executing:
Downgrading typer to
0.12.3
seems to resolve the issue:I will try to check what were the latest changes included in
0.12.4
.I just have a question related to the update of the dependencies: right now we don't "freeze" the versions of the dependencies, is there any good reason? Updates are done automatically, but if there is a failure like we have now we need to identify which dependency update is the source of the issue and all the CI pipelines fail.
What about freezing the versions of the dependencies and letting a bot updating them (e.g. dependabot)?
The text was updated successfully, but these errors were encountered: