Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2FA to password/2FA/email change forms #2291

Open
kiritofeng opened this issue Oct 11, 2023 · 0 comments
Open

Add 2FA to password/2FA/email change forms #2291

kiritofeng opened this issue Oct 11, 2023 · 0 comments
Labels

Comments

@kiritofeng
Copy link
Member

kiritofeng commented Oct 11, 2023

After some more thought, the issue with requiring 2fa is that we need to support all the different types of 2fa (backup code, totp, hardware key), which requires quite a bit of refactoring. Also, at the moment, adding 2fa won't increase security, since a user can regenerate their totp token/get new backup codes without any re-authentication.

I think adding 2fa to this should be part of a future change where we harden everything together, and is out of the scope of the current PR.

Originally posted by @Ninjaclasher in #2290 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant