From 16c2f27492446faa3ab56725e23ed2be79f5527e Mon Sep 17 00:00:00 2001
From: briri <brian.riley@ucop.edu>
Date: Mon, 23 Jan 2023 09:07:17 -0800
Subject: [PATCH] Updated PDF font selector to use Roboto instead of Helvetica
 since Google no longer has Helvetica

updated changelog
---
 CHANGELOG.md                              | 4 +++-
 app/helpers/exports_helper.rb             | 2 +-
 app/models/settings/template.rb           | 2 +-
 app/views/shared/export/_plan_styling.erb | 4 ++--
 4 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index b64a2b09ad..da7e21a9ab 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,9 +1,11 @@
 # Changelog
 
-### Added 
+### Added
 
 - Added CHANGELOG.md and Danger Github Action [#3257](https://github.com/DMPRoadmap/roadmap/issues/3257)
 
 ### Fixed
 
+- Updated sans-serif font used in PDF downloads to Roboto since Google API no longer offers Helvetica
+
 ### Changed
diff --git a/app/helpers/exports_helper.rb b/app/helpers/exports_helper.rb
index a288457477..192ae49914 100644
--- a/app/helpers/exports_helper.rb
+++ b/app/helpers/exports_helper.rb
@@ -10,7 +10,7 @@ module ExportsHelper
   }.freeze
 
   def font_face
-    @formatting[:font_face].presence || 'Arial, Helvetica, Sans-Serif'
+    @formatting[:font_face].presence || 'Roboto, Arial, Sans-Serif'
   end
 
   def font_size
diff --git a/app/models/settings/template.rb b/app/models/settings/template.rb
index a0ee4c6377..dbffe03c23 100644
--- a/app/models/settings/template.rb
+++ b/app/models/settings/template.rb
@@ -18,7 +18,7 @@ module Settings
   class Template < RailsSettings::SettingObject
     VALID_FONT_FACES = [
       '"Times New Roman", Times, Serif',
-      'Arial, Helvetica, Sans-Serif'
+      'Roboto, Arial, Sans-Serif'
     ].freeze
 
     VALID_FONT_SIZE_RANGE = (8..14).freeze
diff --git a/app/views/shared/export/_plan_styling.erb b/app/views/shared/export/_plan_styling.erb
index 7ed339fecc..d8c0f3d059 100644
--- a/app/views/shared/export/_plan_styling.erb
+++ b/app/views/shared/export/_plan_styling.erb
@@ -1,5 +1,5 @@
 <style>
-  @import 'https://fonts.googleapis.com/css?family=<%= font_face.downcase.include?('times') ? 'Times' : 'Helvetica' %>';
+  @import 'https://fonts.googleapis.com/css?family=<%= font_face.downcase.include?('times') ? 'Times' : 'Roboto' %>';
 
   body {
     font-family: <%= font_face %>;
@@ -58,5 +58,5 @@
     }
     .bold {
       font-weight: bold;
-    }  
+    }
 </style>
\ No newline at end of file