Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default template losing 'publicly visible' status when versioned #1415

Closed
briri opened this issue Apr 25, 2018 · 3 comments
Closed

Default template losing 'publicly visible' status when versioned #1415

briri opened this issue Apr 25, 2018 · 3 comments
Assignees
Labels
bug effort-small less than 1/2 day of dev time templates

Comments

@briri
Copy link
Contributor

briri commented Apr 25, 2018

Please complete the following fields as applicable:

Expected behaviour:
The default template should still be visible on the 'Customizable templates' tab of the templates page and available to researchers when they create a plan.

Actual behaviour:
When the default template is versioned, it's visibility is set to 'organisationally visible' if the org that owns it is not a funder

@stephaniesimms
Copy link

stephaniesimms commented Apr 26, 2018

@briri when i test on roadmap and dmptool stage the customized default (Digital Curation Centre) template remains visible in the customizable templates table for admins. but now I can also see the customized version in the public DMP Templates list (see screenshot 1). each time i edit/version the customization it updates this template.

the customized version of the template should not appear in the public list. customizing a template should not update the last edited date for the public template either (although i assume this will be resolved once you complete template versioning work).

I also cannot access the customized default template when I create a new plan. when I go through the create plan wizard and tick the box for "No funder associated" I should see a dropdown list of org templates and the customized default template. But the current behavior doesn't result in a dropdown and instead serves me up an org template "Copy of NIH-GDS" (screenshots 2-3). If i tick both of the boxes for No org and No funder, I do get the default template but not the one customized by UCOP (my org).

screen shot 2018-04-25 at 5 06 37 pm
screen shot 2018-04-25 at 5 29 39 pm
screen shot 2018-04-25 at 5 29 54 pm

@briri
Copy link
Contributor Author

briri commented Apr 26, 2018

ok. this is a larger issue than I originally anticipated. I can exclude the default template from the public templates page, but the current logic behind the create plan page would never find a customized version of the default template.

@stephaniesimms
Copy link

after further discussion, closing this issue and @briri is creating two new issues to address after template versioning is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug effort-small less than 1/2 day of dev time templates
Projects
None yet
Development

No branches or pull requests

2 participants