Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isis2pds Improperly Handling ISIS Mapping Group Radius Units #1797

Closed
ascbot opened this issue Feb 13, 2019 · 4 comments
Closed

isis2pds Improperly Handling ISIS Mapping Group Radius Units #1797

ascbot opened this issue Feb 13, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@ascbot
Copy link
Contributor

ascbot commented Feb 13, 2019


Author Name: Kris Becker (Kris Becker)

Original Date: 2013-10-16
Original Assignee: Kristin Berry


isis2pds assumes the radius units are kilometers when no specific unit specification exists. This is not consistent with other usage and produces erroneous output (off by a factor of 1000) in the PDS product labels.

It should assume all radius values in the EquitorialRadius and PolarRadius keywords are meters unless otherwise explicitly provided.

@ascbot ascbot added this to the 3.4.7 (2014-08-27 Aug) milestone Feb 13, 2019
@ascbot ascbot added the bug Something isn't working label Feb 13, 2019
@ascbot
Copy link
Contributor Author

ascbot commented Feb 13, 2019


Original Redmine Comment
Author Name: Tammy Becker (Tammy Becker)
Original Date: 2013-10-22T19:08:26Z


Moved following text from the 'Impact' field to Notes area.

PDS formatted file products are critical to final archival and exchange of data to collaborators. Improper conversions of ISIS labels compromises our data provisions to our collaborators.

@ascbot
Copy link
Contributor Author

ascbot commented Feb 13, 2019


Original Redmine Comment
Author Name: Kristin Berry (Kristin Berry)
Original Date: 2014-06-06T22:52:32Z


isis2pds assumes that input values are in kilometers when they don't have any unit label. Instead, it should assume that input values without a label are in meters. Output should still be in km as specified in: http://pds.nasa.gov/tools/ddlookup/data_dictionary_lookup.cfm?type=element&letter=M&q=

@ascbot
Copy link
Contributor Author

ascbot commented Feb 13, 2019


Original Redmine Comment
Author Name: Kristin Berry (Kristin Berry)
Original Date: 2014-06-09T23:47:00Z


Built on prog 6 for testing.

@ascbot
Copy link
Contributor Author

ascbot commented Feb 13, 2019


Original Redmine Comment
Author Name: Kris Becker (Kris Becker)
Original Date: 2014-06-24T19:59:16Z


Tested and it worked fine. Thanks...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant