Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions to download data on README are wrong. #3212

Closed
lavalaz opened this issue Apr 8, 2019 · 8 comments · Fixed by #3214
Closed

Instructions to download data on README are wrong. #3212

lavalaz opened this issue Apr 8, 2019 · 8 comments · Fixed by #3214

Comments

@lavalaz
Copy link

lavalaz commented Apr 8, 2019

Description

I followed the instructions on the github page (https://github.com/USGS-Astrogeology/ISIS3#full-isis3-data-download). It dumped data into my home area. I looked around and inferred that I should follow part of the instructions for downloading all the data and copy-pasted the command given in the instructions (cd $ISIS3DATA). Then I tried to update the TGO data, and copy-pasted the command given in the instructions (rsync -azv --delete --partial isisdist.astrogeology.usgs.gov::isis3data/data/tgo data/). Now I have new data in a new folder where ISIS3 won't find it. No error messages or anything to tell the user there is a problem. I only know there is a problem because I spent months debugging my student's ISIS3 installation and know what to look for.

Suggested Edit

I already suggested a fix but that didn't seem to help. At this point I am suggesting you write out the explicit single-line rsync command that will put the data in the right folder on the user's computer.

Thanks!

@jessemapel
Copy link
Contributor

This was updated in the document that is generated for our website in #3170, but not on our github README. It won't take much to copy those changes to our README.

@jessemapel jessemapel changed the title Instructions to download data is still wrong. #3148 is not fixed. Instructions to download data on README is wrong. Apr 8, 2019
@jessemapel
Copy link
Contributor

@lavalaz If you find that a previous issue has not been resolved, you can re-open that issue as the reporter. I'm leaving this open because this is a separate issue. #3148 was for the website documentation, which we will no longer link to. This issue is for our github documentation which we will be directing people to as of 3.7.0

@jessemapel jessemapel self-assigned this Apr 8, 2019
@jessemapel jessemapel changed the title Instructions to download data on README is wrong. Instructions to download data on README are wrong. Apr 8, 2019
@lavalaz
Copy link
Author

lavalaz commented Apr 8, 2019

OK, your edit is correct. I did not realize the webpage is deprecated... Do I need to put in another ticket saying I still get bad instructions if I google for USGS ISIS3 installation help because the old web page is still up? I don't mean to beat a dead horse, but I do want this problem really eliminated. And sorry if I don't know how to help other than be a nag...

@jessemapel
Copy link
Contributor

@lavalaz Don't feel like a nag, this is still a valid issue. The website install instruction page has been updated, but it won't be pushed publicly until the 3.7.0 release when we push all of the updated docs. We may also delete the contents of that page and have it point to out github readme.

@lavalaz
Copy link
Author

lavalaz commented Apr 8, 2019

OK, thanks! And for what its worth, I totally support the idea of having only one place for install instructions (i.e., delete the contents of the current page and point people to github).

@jessemapel
Copy link
Contributor

@lavalaz Agreed, we have already started working on this consolidation in #3178

@jessemapel
Copy link
Contributor

@lavalaz Instructions should be fixed now. If you think there's still ambiguity in anything please re-open this issue.

@lavalaz
Copy link
Author

lavalaz commented Apr 9, 2019

I just copy-pasted and worked fine and the instructions should be clear to any prospective user. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants