Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify mosrange to Not Abort on Bad Images #3606

Closed
KrisBecker opened this issue Dec 16, 2019 · 6 comments
Closed

Modify mosrange to Not Abort on Bad Images #3606

KrisBecker opened this issue Dec 16, 2019 · 6 comments
Labels
enhancement New feature or request Missions Issues which are a priority for missions
Milestone

Comments

@KrisBecker
Copy link
Contributor

Description

Occasionally, mosrange would fail on one or more images which aborts the application. We altered mosrange to trap failing calculations for each image, log the image and remove it from the list. mosrange continues to completion processing as many image cubes as possible.

We found that this issue could occur rather frequently and randomly due to issues with SPICE data and shape models. Producing lists of failing images allows one to investigate the underlying issues.

Three new parameters were added: ERRORLOG, ERRRORLIST and ONERROR.

ERRORLOG allows the user to provide the name of a file where the error is reported.

ERRORLIST allows the user to provide the name of a file where the name of failed images are written.

ONERROR can be used by the user to choose how these file errors are handled when they occur. ONERROR=FAIL preserves pre-existing behavior and will result in a program error.

Example

[113]: mosrange -h
FROMLIST   = Null
MAP        = Null
TO         = Null
LOG        = Null
ERRORLOG   = Null
ERRORLIST  = Null
PROJECTION = None
LATTYPE    = (*PLANETOCENTRIC, PLANETOGRAPHIC)
LONDIR     = (*POSITIVEEAST, POSITIVEWEST)
LONDOM     = (*360, 180)
PRECISION  = 12
ONERROR    = (CONTINUE, *FAIL)

@jessemapel jessemapel added enhancement New feature or request Missions Issues which are a priority for missions labels Dec 16, 2019
@jessemapel
Copy link
Contributor

Why this is important

If working with the current version of mosrange, weeding out bad images requires iteratively running the application. This can be a time consuming and tedious process when working with large volumes of data. By allowing mosrange to do as much as possible, you can run mosrange once then remove and/or check all of the bad images in a single pass. It is also easier and more robust to automate removal of bad images via an output list instead of having to parse exception messages.

@ascbot
Copy link
Contributor

ascbot commented Sep 1, 2020

I am a bot that cleans up old issues that do not have activity.

This issue has not received feedback in the last six months. I am going to add the inactive label to
this issue. If this is still a pertinent issue, please add a comment or add an emoji to an existing comment.

I will post again in five months with another reminder and will close this issue on it's birthday unless it has
some activity.

@ascbot ascbot added the inactive Issue that has been inactive for at least 6 months label Sep 1, 2020
@jessemapel jessemapel removed the inactive Issue that has been inactive for at least 6 months label Sep 1, 2020
@jessemapel
Copy link
Contributor

This is still outstanding

@github-actions
Copy link

Thank you for your contribution!

Unfortunately, this issue hasn't received much attention lately, so it is labeled as 'stale.'

If no additional action is taken, this issue will be automatically closed in 180 days.

@github-actions github-actions bot added the inactive Issue that has been inactive for at least 6 months label May 26, 2021
@AustinSanders AustinSanders added this to the 6.1.0 milestone Aug 5, 2021
@github-actions github-actions bot closed this as completed Feb 2, 2022
@AustinSanders
Copy link
Contributor

Reopened by request

@AustinSanders AustinSanders reopened this Aug 3, 2023
@AustinSanders AustinSanders removed the inactive Issue that has been inactive for at least 6 months label Aug 3, 2023
@AustinSanders
Copy link
Contributor

Closed via #5292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Missions Issues which are a priority for missions
Projects
None yet
Development

No branches or pull requests

4 participants