Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hideal2pds outputs a label where SAMPLE_BITS value is always 16 #4006

Closed
tgiroux opened this issue Sep 8, 2020 · 0 comments · Fixed by #4500
Closed

hideal2pds outputs a label where SAMPLE_BITS value is always 16 #4006

tgiroux opened this issue Sep 8, 2020 · 0 comments · Fixed by #4500
Assignees
Labels
bug Something isn't working
Milestone

Comments

@tgiroux
Copy link
Contributor

tgiroux commented Sep 8, 2020

ISIS version(s) affected: 4.2.0

Description

When a user selects bits=8, the SAMPLE_BITS value in the output label should be 8. For all other cases (bits=9-16), SAMPLE_BITS should be 16. At present it is 16 for all cases including bits=8.

How to reproduce

In isis/src/mro/apps/hideal2pds/tsts/differentBitCompressions run $make output and check output/output8.pvl to see that SAMPLE_BITS=16

Possible Solution

Include the following code within IsisMain() of main.cpp for hideal2pds:
if( nbits == 8 ) {
image.addKeyword(PvlKeyword("SAMPLE_BITS", toString(nbits)), Pvl::Replace);
}

Additional context

Related to #3978 by @audiefen

@jlaura jlaura added the bug Something isn't working label Sep 30, 2020
@jessemapel jessemapel modified the milestone: 4.3.1 Dec 14, 2020
@acpaquette acpaquette added this to the 5.0.1 milestone Apr 10, 2021
@tgiroux tgiroux self-assigned this Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants