You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Given the current ISIS core work, there is a coupling between PvlObject and the Application class. Where the PvlObject accesses the Application static function Log to place output into an applications terminal.
This is a poor coupling and should be up to the Application class to log data to the application terminal and add any relevant PVL data to a Pvl object.
Ideally, we would deprecate the PvlObject function addLogGroup for a new function on to Application called something like appendAndLog, with two inputs the PvlGroup to log and the output Pvl object. Where it would log to the application terminal and if a Pvl object were passed in, add the results group to the Pvl object.
Function signature
appendAndLog(PvlGroup &results, Pvl &log)
The text was updated successfully, but these errors were encountered:
Given the current ISIS core work, there is a coupling between
PvlObject
and theApplication
class. Where thePvlObject
accesses theApplication
static functionLog
to place output into an applications terminal.This is a poor coupling and should be up to the
Application
class to log data to the application terminal and add any relevant PVL data to aPvl
object.Ideally, we would deprecate the
PvlObject
functionaddLogGroup
for a new function on toApplication
called something likeappendAndLog
, with two inputs thePvlGroup
to log and the outputPvl
object. Where it would log to the application terminal and if aPvl
object were passed in, add the results group to thePvl
object.Function signature
The text was updated successfully, but these errors were encountered: