Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add corner-cases in checkContacts #6

Closed
ineiti opened this issue Apr 15, 2020 · 2 comments
Closed

Add corner-cases in checkContacts #6

ineiti opened this issue Apr 15, 2020 · 2 comments

Comments

@ineiti
Copy link
Contributor

ineiti commented Apr 15, 2020

The current implementation of checkContacts supposes that the clocks between the sender and receiver are perfectly synchronized. It should test the day before and the day after the proposed epoch, too.

See also DP-3T/documents#135

@LCBH
Copy link

LCBH commented Apr 17, 2020

For security reasons, it should neither check for the the day bucketDate nor for the day after bucketDate. See #17.

Regarding clock desynchronization, the specification is even too liberal in that it does not prevent easy targeted false positives, should such desynchronization happen. See issue reference_implementation/#12 and issue documents/#99.

@stmitt
Copy link
Contributor

stmitt commented May 28, 2020

We recently undertook a massive refactoring to integrate Apple's official ExposureNotification framework in favour of our custom Bluetooth and Key-generation implementation. Going forward, we will only support the official Apple framework that handles all bluetooth communication. Please update to the latest SDK version and subscribe to the notifications so you keep up to date with the latest changes.

@stmitt stmitt closed this as completed May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants