Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Players can't finish a dungeon if someone from their group leaves #327

Closed
ghost opened this issue Nov 2, 2017 · 3 comments
Closed

Players can't finish a dungeon if someone from their group leaves #327

ghost opened this issue Nov 2, 2017 · 3 comments
Milestone

Comments

@ghost
Copy link

ghost commented Nov 2, 2017

When they hit the sign, it tells them "You've completed blabla" (and not "you have to wait for blabla") but they don't get teleported back to the main world. They can use /dxl leave, of course, but their rewards will be gone. Kinda pointless.
I have a denizen script executing /dxl leave on any player who leaves the dungeon (if world name contains DXL, then blabla), in fact their name disappears from the sign.

Map config: https://hastebin.com/afocuyuhoh.coffeescript

Kind of a severe...

@Sataniel98
Copy link
Member

Note that the default value for timeUntilKickOfflinePlayer is -1, so provided that you do not have any settings in a different game rule provider (e.g. main config), players will never get kicked from their group at all if they leave and are therefore still supposed to reach the end. But I think I'll set the default value to 0 instead, since most users will rather need this.

@Sataniel98 Sataniel98 added this to the Beta 0.16-HOTFIX milestone Nov 2, 2017
@ghost
Copy link
Author

ghost commented Nov 2, 2017

Well, denizen executes /dxl leave for them if they log out, so that -1 shouldn't be a problem at all

@ghost
Copy link
Author

ghost commented Nov 2, 2017

Oh, ok, wait: someone put timeUntileKickOfflinePlayer on 60 in the main config.yml (...).
I changed it with 0 and now, even without the denizen code, it seems to work :) So I guess the bug appears when timeUntilecc. is more than 0..?

EDIT: also if I press "end" and the other one leaves

EDIT 2: Just kidding, the bug persists even with 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant