Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge authentication provider #1596

Closed
dominik003 opened this issue Jun 1, 2024 · 0 comments · Fixed by #1587
Closed

Merge authentication provider #1596

dominik003 opened this issue Jun 1, 2024 · 0 comments · Fixed by #1587
Assignees

Comments

@dominik003
Copy link
Contributor

Currently we have two different authentication implementations, one for OAuth via azure and a more general variant. The reason for this seems to be that in the case of azure we can use the Microsoft Authentication Library (MSAL) for Python. However, most of the logic between the implementations is duplicated, and there is nothing preventing us from using the more general variant in the Azure case as well. Therefore, we want to merge the two authentication flows and remove any provider-specific details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant