Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-r / --region switch fails if not set #44

Closed
xanthospap opened this issue Dec 3, 2018 · 2 comments
Closed

-r / --region switch fails if not set #44

xanthospap opened this issue Dec 3, 2018 · 2 comments
Labels
bug
Milestone
v1.0

Comments

@xanthospap
Copy link
Contributor

Describe the bug
StrainTool fails if -r / --region switch fails if not set in command line

To Reproduce
Steps to reproduce the behavior:

  1. run command 'StrainTool ' without setting "-r"
  2. check for error 'NameError: name 'region' is not defined'

Expected behavior
No error

Screenshots

Desktop (please complete the following information):

  • OS: [Linux]
  • Python: [2.7]
  • GMT: [e.g. 5.2.1]
  • StrainTool: [v1.0-rc3]

Additional context
Add any other context about the problem here.
@xanthospap
Copy link
Contributor Author

To fix:

replace the check if args.region with if 'region' in args:. This behavior is caused by suppressing default values for certain options, via the default=argparse.SUPPRESS option in parser.add_argument.

@demanasta demanasta added the bug label Dec 3, 2018
@demanasta demanasta added this to the v1.0 milestone Dec 3, 2018
@xanthospap
Copy link
Contributor Author

Fixed in branch dev

@demanasta demanasta mentioned this issue Dec 14, 2018
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
2 participants
@xanthospap @demanasta