Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default register the SettingsController singleton #204

Merged
merged 1 commit into from
Jun 28, 2021
Merged

fix: default register the SettingsController singleton #204

merged 1 commit into from
Jun 28, 2021

Conversation

wewoor
Copy link
Collaborator

@wewoor wewoor commented Jun 28, 2021

No description provided.

@wewoor wewoor requested a review from mortalYoung June 28, 2021 02:53
@wewoor wewoor added this to the 0.9.0-alpha.3 milestone Jun 28, 2021
mortalYoung
mortalYoung approved these changes Jun 28, 2021
View reviewed changes
Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 442b1a9 into main Jun 28, 2021
@wewoor wewoor deleted the fix/settings branch June 28, 2021 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortalYoung mortalYoung mortalYoung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0-alpha.3
Development

Successfully merging this pull request may close these issues.
2 participants
@wewoor @mortalYoung