Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve type definition of editor tab #341

Merged
merged 1 commit into from
Aug 18, 2021
Merged

fix: improve type definition of editor tab #341

merged 1 commit into from
Aug 18, 2021

Conversation

mortalYoung
Copy link
Collaborator

简介

  • 修复 editor 的 tab 类型定义,不加 key 的话,用户在 tab.data 中添加自己的数据的时候,会有 ts 的报错

@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #341 (d81b431) into main (20d6b93) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #341   +/-   ##
=======================================
  Coverage   52.95%   52.95%           
=======================================
  Files         173      173           
  Lines        4604     4604           
  Branches     1016     1016           
=======================================
  Hits         2438     2438           
  Misses       2138     2138           
  Partials       28       28           
Impacted Files Coverage Δ
src/model/workbench/editor.ts 62.06% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20d6b93...d81b431. Read the comment docs.

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 22597b4 into main Aug 18, 2021
@wewoor wewoor deleted the fix/editor branch August 18, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants