Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent page broken via folderTree #358

Merged
merged 1 commit into from
Aug 23, 2021
Merged

fix: prevent page broken via folderTree #358

merged 1 commit into from
Aug 23, 2021

Conversation

mortalYoung
Copy link
Collaborator

简介

  • 优化 helper 代码,防止由于相同 id 导致寻找树节点失败,进而导致页面崩溃的问题

主要变更

  • 添加非空判断

Related Issues

Closed #357

@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #358 (625219a) into main (9dd5e4a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #358   +/-   ##
=======================================
  Coverage   58.38%   58.38%           
=======================================
  Files         173      173           
  Lines        4655     4655           
  Branches     1023     1024    +1     
=======================================
  Hits         2718     2718           
  Misses       1916     1916           
  Partials       21       21           
Impacted Files Coverage Δ
src/services/helper.ts 87.30% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dd5e4a...625219a. Read the comment docs.

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor added this to the 0.9.0-alpha.5 milestone Aug 23, 2021
@wewoor wewoor merged commit 160a798 into main Aug 23, 2021
@wewoor wewoor deleted the fix/helper branch August 23, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improvement: Program Broken when create a folder in a folder
2 participants