Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: renderPane exec twice #439

Merged
merged 1 commit into from
Sep 18, 2021
Merged

fix: renderPane exec twice #439

merged 1 commit into from
Sep 18, 2021

Conversation

mortalYoung
Copy link
Collaborator

简介

  • 修复 renderPane 会执行两次的问题

主要变更

  • 发现 tabs 这个组件里面会执行一次,然后 editor 或者 panel 又会执行一次
  • 其实之前测试用例应该有发现这个问题,但是以为这是一个 feature

Related Issues

Closed #435

@mortalYoung mortalYoung added the bug Something isn't working label Sep 17, 2021
@mortalYoung mortalYoung added this to the 0.9.0-beta.1 milestone Sep 17, 2021
@mortalYoung mortalYoung self-assigned this Sep 17, 2021
@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #439 (b783e75) into main (3dc3f49) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #439      +/-   ##
==========================================
- Coverage   81.10%   81.06%   -0.04%     
==========================================
  Files         177      177              
  Lines        4890     4881       -9     
  Branches     1053     1050       -3     
==========================================
- Hits         3966     3957       -9     
  Misses        915      915              
  Partials        9        9              
Impacted Files Coverage Δ
src/components/tabs/index.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dc3f49...b783e75. Read the comment docs.

ProfBramble
ProfBramble approved these changes Sep 17, 2021
@mortalYoung mortalYoung merged commit 5eb14a5 into main Sep 18, 2021
@mortalYoung mortalYoung deleted the fix/renderPane branch September 18, 2021 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: renderPane will exec twice somethings
2 participants