Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support to subscribe the drop event in tree #450

Merged
merged 3 commits into from
Sep 29, 2021
Merged

feat: support to subscribe the drop event in tree #450

merged 3 commits into from
Sep 29, 2021

Conversation

mortalYoung
Copy link
Collaborator

简介

  • tree 组件支持拖拽事件

主要变更

  • 原先的拖拽没有支持事件订阅
  • 目前的支持的拖拽优化了 api,不再输出整棵树,而是通过把 source 和 target 传给使用者,然后使用者进行操作,更加人性化
  • 不支持拖拽改变顺序等操作

@mortalYoung mortalYoung added this to the 0.9.0-beta.1 milestone Sep 27, 2021
@mortalYoung mortalYoung self-assigned this Sep 27, 2021
@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #450 (6901598) into main (1b0aa04) will increase coverage by 0.08%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
+ Coverage   80.78%   80.87%   +0.08%     
==========================================
  Files         177      177              
  Lines        4913     4894      -19     
  Branches     1065     1058       -7     
==========================================
- Hits         3969     3958      -11     
+ Misses        935      927       -8     
  Partials        9        9              
Impacted Files Coverage Δ
src/model/workbench/explorer/folderTree.tsx 47.36% <ø> (ø)
src/controller/explorer/folderTree.tsx 20.00% <33.33%> (-0.29%) ⬇️
src/components/tree/index.tsx 98.41% <100.00%> (+9.38%) ⬆️
...c/services/workbench/explorer/folderTreeService.ts 97.36% <100.00%> (+0.90%) ⬆️
src/workbench/sidebar/explore/folderTree.tsx 97.56% <100.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b0aa04...6901598. Read the comment docs.

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 8626600 into main Sep 29, 2021
@wewoor wewoor deleted the feat/drop branch September 29, 2021 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants