Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve the insert strategy in folderTree #486

Merged
merged 2 commits into from
Oct 28, 2021
Merged

fix: improve the insert strategy in folderTree #486

merged 2 commits into from
Oct 28, 2021

Conversation

mortalYoung
Copy link
Collaborator

简介

  • 优化文件夹树插入结点策略

主要变更

  • 防止插入结点的时候一会儿 prepend 一会儿 append

@mortalYoung mortalYoung added the bug Something isn't working label Oct 28, 2021
@mortalYoung mortalYoung self-assigned this Oct 28, 2021
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #486 (2b0a1f7) into main (22a59c7) will increase coverage by 0.39%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
+ Coverage   85.14%   85.53%   +0.39%     
==========================================
  Files         180      180              
  Lines        5284     5296      +12     
  Branches     1187     1192       +5     
==========================================
+ Hits         4499     4530      +31     
+ Misses        778      759      -19     
  Partials        7        7              
Impacted Files Coverage Δ
src/controller/explorer/folderTree.tsx 100.00% <100.00%> (ø)
...c/services/workbench/explorer/folderTreeService.ts 99.31% <100.00%> (+0.06%) ⬆️
src/model/workbench/explorer/folderTree.tsx 92.00% <0.00%> (+76.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22a59c7...2b0a1f7. Read the comment docs.

@wewoor wewoor added this to the 0.9.0-beta.1 milestone Oct 28, 2021
Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 3061b68 into main Oct 28, 2021
@wewoor wewoor deleted the fix/folderTree branch October 28, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants