Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix can't clear the notifications #518

Merged
merged 3 commits into from
Nov 23, 2021
Merged

fix: fix can't clear the notifications #518

merged 3 commits into from
Nov 23, 2021

Conversation

mortalYoung
Copy link
Collaborator

@mortalYoung mortalYoung commented Nov 23, 2021

简介

  • 修复 notifications 无法清楚的问题
  • 修复调用 service.toggleNotifications 无法生效的问题

Related Issues

Closed #516

@mortalYoung mortalYoung self-assigned this Nov 23, 2021
@mortalYoung mortalYoung added the bug Something isn't working label Nov 23, 2021
@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #518 (1ff686b) into main (76f2be1) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
- Coverage   85.57%   85.56%   -0.02%     
==========================================
  Files         182      182              
  Lines        5312     5301      -11     
  Branches     1188     1186       -2     
==========================================
- Hits         4546     4536      -10     
+ Misses        759      758       -1     
  Partials        7        7              
Impacted Files Coverage Δ
src/controller/notification.tsx 100.00% <100.00%> (+2.56%) ⬆️
src/services/notificationService.ts 100.00% <100.00%> (ø)
src/workbench/notification/statusBarView/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76f2be1...1ff686b. Read the comment docs.

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 2503f4a into main Nov 23, 2021
@wewoor wewoor deleted the fix/notification branch November 23, 2021 07:53
wewoor pushed a commit that referenced this pull request Dec 1, 2021
* fix: fix can't clear the notifications

* test: update tests

* test: ignore render tests
wewoor added a commit that referenced this pull request Dec 6, 2021
* docs: update the introduction

* docs: update the Introduction of zhCN version

* docs: tutorials for keybinding, quickAccess and Icon

* feat: improve homepage (#527)

* build: update the limitation of node version (#515)

* fix: fix can't clear the notifications (#518)

* fix: fix can't clear the notifications

* test: update tests

* test: ignore render tests

* fix: fix create file node incorrect on contextMenu (#522)

* refactor:  optimize the MoleculeProvider (#517)

* refactor: update the MoleculeProvider

* fix(molecule provider): init workbench ui after init locales

* test: unit test for splitLanguagesExts

* docs: comments for MoleculeProvider

* test: unit test for MoleculeProvider

* refactor(i18n): update the apis of locales

* fix: correct the reset to rest

* chore: ignore website prettier

* style: prettify code

* test: update the snapshot case

* test: remove the snapshot

* test: update snapshot

* ci:  yarn test -u

* ci: remove the -u argument of yarn test

* test: update the MoleculeProvider snap

* fix: show the SubMenu in right place when the Menu is horizontal mode (#526)

* fix: show the submenu in right place when horizontal mode

* test: update the snap of Menu

* feat: support sort in folderTree (#524)

* feat: support sort in folderTree

* feat: improve check hidden files

* docs: update Guides

* docs: unify the files name

* docs: update Guides, Overview

* docs: update the QuickStart

* docs: update the first extension

* docs: update the extension guides

* docs: update Workbench UI

* fix: improve the circular dep error when execute yarn link (#528)

* fix: remove the warning in console (#529)

* fix: remove the warning in console

* test: update snapshots

* docs: update ColorTheme, readme, keybinding, i18n

* docs: update Keybinding

* docs: update quickAccess, add demo tips

* docs: update i18n

* docs: update Settings guide

* docs: update Icon guide

* docs: update customize the Workbench guide

* docs: update images

* docs: update Contributing

* docs: update English version

* fix: remove the 140 width limit for buttons

* docs: default locale is zh-CN

* docs: improve the links (#533)

Co-authored-by: 野迂迂 <yangwei1@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The molecule.notification.toggleNotification not work
2 participants