Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove the onRemove processing logic in the built-in FolderTree extension #617

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

kiwiwong
Copy link
Collaborator

Description

Move the node removal logic from the built-in FolderTree extension to the test extension.

Fixes #583

@kiwiwong kiwiwong self-assigned this Jan 12, 2022
@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #617 (9639ea2) into main (bfdf0bb) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
+ Coverage   88.88%   88.92%   +0.03%     
==========================================
  Files         185      185              
  Lines        5409     5416       +7     
  Branches     1218     1222       +4     
==========================================
+ Hits         4808     4816       +8     
+ Misses        593      592       -1     
  Partials        8        8              
Impacted Files Coverage Δ
src/extensions/folderTree/index.tsx 22.22% <ø> (-2.78%) ⬇️
...c/services/workbench/explorer/folderTreeService.ts 99.41% <0.00%> (+0.02%) ⬆️
src/model/workbench/explorer/folderTree.tsx 92.59% <0.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfdf0bb...9639ea2. Read the comment docs.

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor added the refactoring Refactor label Jan 13, 2022
@wewoor wewoor added this to the Next Version milestone Jan 13, 2022
Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 7a77374 into main Jan 13, 2022
@wewoor wewoor deleted the fix/folderTree branch January 13, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: remove folderTree node
3 participants