-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Connect component supports to unsubscribe event by pass the callback #635
Conversation
Codecov Report
@@ Coverage Diff @@
## main #635 +/- ##
==========================================
+ Coverage 89.02% 89.03% +0.01%
==========================================
Files 184 184
Lines 5412 5418 +6
Branches 1222 1224 +2
==========================================
+ Hits 4818 4824 +6
Misses 586 586
Partials 8 8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Description
修复
connect
Service 多次后,组件销毁后,导致事件无效的问题Fixes #596
Changes
EventEmitter
支持通过事件name
和callback
函数引用取消订阅connect
HOC 组件,按callback
取消事件订阅How Has This Been Tested?