Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent updateTab with renderPanel tab #781

Merged
merged 2 commits into from
Jul 14, 2022
Merged

fix: prevent updateTab with renderPanel tab #781

merged 2 commits into from
Jul 14, 2022

Conversation

mortalYoung
Copy link
Collaborator

简介

  • 修复在某些情况下 updateTab 会更新错误 tab 的内容

主要变更

  • 当存在非编辑器 tab 的时候,该 tab 调用 updateTab,会导致更新 editorInstance 的内容,从而导致更新错误 tab 的内容

Related Issues

Closed #780

@mortalYoung mortalYoung added the bug Something isn't working label Jul 14, 2022
@mortalYoung mortalYoung requested a review from Zaoei July 14, 2022 07:56
@mortalYoung mortalYoung self-assigned this Jul 14, 2022
@mortalYoung mortalYoung requested a review from wewoor July 14, 2022 07:57
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #781 (3972aae) into main (a8b608d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #781      +/-   ##
==========================================
+ Coverage   91.02%   91.04%   +0.02%     
==========================================
  Files         180      180              
  Lines        5784     5786       +2     
  Branches     1400     1402       +2     
==========================================
+ Hits         5265     5268       +3     
+ Misses        513      512       -1     
  Partials        6        6              
Impacted Files Coverage Δ
src/services/workbench/editorService.ts 98.27% <100.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8b608d...3972aae. Read the comment docs.

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 2d77923 into main Jul 14, 2022
@wewoor wewoor deleted the fix/updateTab branch July 14, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: updateTab will update wrong tab
2 participants