Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust the order of controller #831

Merged
merged 1 commit into from
Nov 23, 2022
Merged

fix: adjust the order of controller #831

merged 1 commit into from
Nov 23, 2022

Conversation

mortalYoung
Copy link
Collaborator

简介

  • 修复在某些情况下无法添加 headerBar 的问题

Related Issues

Closed #829

@mortalYoung mortalYoung added the bug Something isn't working label Nov 22, 2022
@mortalYoung mortalYoung self-assigned this Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 91.15% // Head: 91.15% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (07720d7) compared to base (9418d40).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #831   +/-   ##
=======================================
  Coverage   91.15%   91.15%           
=======================================
  Files         180      180           
  Lines        5797     5798    +1     
  Branches     1408     1408           
=======================================
+ Hits         5284     5285    +1     
  Misses        507      507           
  Partials        6        6           
Impacted Files Coverage Δ
src/services/instanceService.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 8a63067 into main Nov 23, 2022
@wewoor wewoor deleted the fix/headerBar branch November 23, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: controller.initView should called in specific order
2 participants