Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace the Codicon.gear.classNames with codicon string #847

Merged
merged 8 commits into from
Apr 3, 2023
Merged

Conversation

wewoor
Copy link
Collaborator

@wewoor wewoor commented Feb 23, 2023

Description

The current moanco-editor version removed the built-in gear icon from Codicon.

Changes

  • update Codicon.gear.classNames

@wewoor wewoor added the bug Something isn't working label Feb 23, 2023
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (bc31969) 91.05% compared to head (4f64460) 91.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #847      +/-   ##
==========================================
+ Coverage   91.05%   91.06%   +0.01%     
==========================================
  Files         188      188              
  Lines        6071     6078       +7     
  Branches     1476     1476              
==========================================
+ Hits         5528     5535       +7     
  Misses        537      537              
  Partials        6        6              
Impacted Files Coverage Δ
src/model/workbench/layout.ts 100.00% <ø> (ø)
src/monaco/quickAccessViewAction.ts 10.41% <ø> (ø)
src/controller/layout.ts 100.00% <100.00%> (ø)
src/provider/create.ts 100.00% <100.00%> (ø)
src/services/instanceService.tsx 100.00% <100.00%> (ø)
src/services/workbench/layoutService.ts 100.00% <100.00%> (ø)
src/workbench/workbench.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

wewoor and others added 6 commits February 23, 2023 16:18
* build: update testing-library and typescript

* build: upgrade source-map

* build: update yarn and yarn.lock

* build: update jest and pnpm-lock
* feat: support onWorkbenchDidMount event

* test: unit test for onWorkbenchDidMount event

* fix: initWorkspace after workbench did mount

* feat: add EmbeddedWorkbench example

* fix: rename standalone
@wewoor wewoor merged commit ded6b52 into main Apr 3, 2023
@wewoor wewoor deleted the fix/icon branch April 3, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant