Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compare incoming value with modal's value #887

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

jin-sir
Copy link
Contributor

@jin-sir jin-sir commented Jun 13, 2024

Description

There exists a infinite loop.Determine whether to update the modal value based on comparing the passed-in value and the modal value.

Fixes # (issue)

#881

@jin-sir jin-sir marked this pull request as draft June 13, 2024 15:27
@jin-sir jin-sir marked this pull request as ready for review June 13, 2024 15:29
@jin-sir jin-sir changed the title fix: not set the modal's value in the current tab fix: compare incoming value with modal's value Jun 14, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.92%. Comparing base (555abe1) to head (96187df).

Files Patch % Lines
src/services/workbench/editorService.ts 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #887      +/-   ##
==========================================
- Coverage   90.94%   90.92%   -0.03%     
==========================================
  Files         188      188              
  Lines        6085     6093       +8     
  Branches     1449     1478      +29     
==========================================
+ Hits         5534     5540       +6     
- Misses        546      547       +1     
- Partials        5        6       +1     
Flag Coverage Δ
integration 90.92% <75.00%> (-0.03%) ⬇️
unittests 90.92% <75.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mortalYoung mortalYoung merged commit 9ade524 into DTStack:main Jun 18, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants