From d251dd51748921e93aebceff2e9970a392fd4b1b Mon Sep 17 00:00:00 2001 From: mortalYoung Date: Wed, 7 Jul 2021 16:38:04 +0800 Subject: [PATCH 1/2] fix: prevent the show of native contextMenu in tab --- src/components/tabs/tab.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/src/components/tabs/tab.tsx b/src/components/tabs/tab.tsx index 1ef66a93c..d25e9fd2c 100644 --- a/src/components/tabs/tab.tsx +++ b/src/components/tabs/tab.tsx @@ -61,6 +61,7 @@ export function Tab(props: ITabProps) { const handleMouseOut = () => setHover(false); const handleOnContextMenu = useCallback( (event: React.MouseEvent) => { + event.preventDefault(); onContextMenu?.(event, props); }, [props] From 2ad23f94ec2dbcb204a0aa46fc1894a5d96501df Mon Sep 17 00:00:00 2001 From: mortalYoung Date: Wed, 7 Jul 2021 16:39:23 +0800 Subject: [PATCH 2/2] fix: improve the active style of acitivity bar --- src/style/theme/activitybar.scss | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/style/theme/activitybar.scss b/src/style/theme/activitybar.scss index 1037bcf3d..bb903fe14 100644 --- a/src/style/theme/activitybar.scss +++ b/src/style/theme/activitybar.scss @@ -10,22 +10,18 @@ background: var(--activityBar-activeBorder); } - &__item--checked { - #{$activityBar}__label { - background-color: var(--activityBar-activeBackground); - border-color: var(--activityBar-activeFocusBorder); - color: var(--activityBar-activeBorder); - } - } - &__item { color: var(--activityBar-inactiveForeground); &:hover, - &__label .codicon { + &__label { background-color: var(--activityBar-activeBackground); border-color: var(--activityBar-activeBorder); color: var(--activityBar-activeBorder); } } + + &__item--checked { + color: var(--activityBar-activeBorder); + } }