Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation #1

Open
Daddoon opened this issue Mar 1, 2019 · 2 comments
Open

Documentation #1

Daddoon opened this issue Mar 1, 2019 · 2 comments

Comments

@Daddoon
Copy link
Owner

Daddoon commented Mar 1, 2019

Add documentation in methods when needed.
Source: https://mozilla.github.io/geckoview/javadoc/mozilla-central/org/mozilla/geckoview/package-tree.html

@Daddoon
Copy link
Owner Author

Daddoon commented Mar 3, 2019

javadoc jar has been added on the project, but even if everything is configured, Visual Studio fail to match documentation / C# api.

So it's not working at the moment.
Also there is a bug that prevent JavaDocs to compile with the default VS2019 Xamarin.Android build target.

In Xamarin.Android.Bindings.targets in the MSBuild for the moment we must replace:

<Touch Files="@(JavaDocJar->'$(IntermediateOutputPath)javadocs\%(FileName).stamp')" /> 

To

<Touch Files="@(JavaDocJar->'$(IntermediateOutputPath)javadocs\%(FileName).stamp')" AlwaysCreate="True" />

Also see: dotnet/android#2745

@Daddoon
Copy link
Owner Author

Daddoon commented Jul 19, 2019

As quoted:

Steps to Reproduce

  1. I tried to create a binding library from glide
    download glide-3.7.0-javadoc.jar glide-3.7.0.jar and set action build to JavaDocJar
  2. build binding library

Expected Behavior

build success and binding library has original Java parameter

Actual Behavior

build error xxxx.stamp not exist

Version Information

Log File

Xamarin.Android.Bindings.targets
<Touch Files="@(JavaDocJar->'$(IntermediateOutputPath)javadocs\%(FileName).stamp')" />
maybe miss the attribute AlwaysCreate="True"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant