Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in support for more Node, Python and Ruby files #357

Merged
merged 3 commits into from
May 9, 2016
Merged

Add in support for more Node, Python and Ruby files #357

merged 3 commits into from
May 9, 2016

Conversation

jamieconnolly
Copy link
Contributor

  • Adjusted size/alignment of the Python icon (current one is too small)
  • Added in quite a few icon listings for Node, Python and Ruby files

@Alhadis
Copy link
Member

Alhadis commented May 9, 2016

Don't get too carried away with the size adjustments. They're getting revamped in V2 anyway.

I believe .python-version is already assigned a gear icon instead of a Python one, since it represents configuration rather than Python code. As for .node-version, well, shouldn't that be using the NodeJS icon rather than the NPM logo?

@jamieconnolly
Copy link
Contributor Author

Ok, that was the only one that bugged me whenever I was working with Python files.

It was, but the .ruby-version file is assigned to the Ruby icon so I just copied that precedent. Do you think all of these *-version files should use the gear icon, or should they use their individual language icon? If it's the latter, I completely agree on the .node-version using the NodeJS icon.

@Alhadis
Copy link
Member

Alhadis commented May 9, 2016

Hrm, the latter, I suppose.

@jamieconnolly
Copy link
Contributor Author

Ok, I've updated the .node-version to use the NodeJS icon, and updated the CHANGELOG accordingly. Thanks for your guidance 👍

@Alhadis Alhadis merged commit 9380223 into file-icons:master May 9, 2016
@Alhadis
Copy link
Member

Alhadis commented May 9, 2016

Still felt this would've been a better solution, BTW.

@jamieconnolly jamieconnolly deleted the improve-node-python-ruby-support branch May 9, 2016 13:52
Alhadis added a commit that referenced this pull request May 10, 2016
@Alhadis Alhadis added filetype-support New file-extensions or filename patterns associated with an existing icon. styling Questions and bugs related to package and user stylesheets. labels Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filetype-support New file-extensions or filename patterns associated with an existing icon. styling Questions and bugs related to package and user stylesheets.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants