Single firmware for both 1Gbit and 2Gbit Rev10 boards #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### `CMakeLists.txt` * Remove newly added 2Gbit firmware type #### `nand/nand_ftl_diskio.c` * Allow SPI NAND initialization to populate the dhara parameters dynamically #### `nand/spi_nand.c` * `spi_nand_init()` now fills in the `struct dhara_nand` * static global page buffer is now maximum size for all supported nand chips (64 bytes extra RAM on 1Gbit Rev10) ... renamed buffer to catch and replace all uses and replace any `sizeof(buffer)` style length with a length calculated based on detected NAND chip. * Track pointer to detected chip in global variable `g_Actual_Nand_Device` * Function `read_id()` now fills the `nand_identity_t` structure, does not validate the data (now done in `spi_nand_init()`) * Converted some `#define` symbols into macros * use `void *` instead of `uint8_t *` when buffer type is variable type/size * in `spi_nand.c`, rename static `reset()` function as `spi_nand_reset()` to reduce likelihood of clashing with other functions. #### Other random bits * Rename `SPI_NAND_PAGES_PER_BLOCK` --> `SPI_NAND_PAGES_PER_ERASE_BLOCK` * minor formatting tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMakeLists.txtnand/nand_ftl_diskio.cnand/spi_nand.cspi_nand_init()now fills in thestruct dhara_nandsizeof(buffer)style length with a length calculated based on detected NAND chip.g_Actual_Nand_Deviceread_id()now fills thenand_identity_tstructure, does not validate the data (now done inspi_nand_init())#definesymbols into macrosvoid *instead ofuint8_t *when buffer type is variable type/sizespi_nand.c, rename staticreset()function asspi_nand_reset()to reduce likelihood of clashing with other functions.Other random bits
SPI_NAND_PAGES_PER_BLOCK-->SPI_NAND_PAGES_PER_ERASE_BLOCK