RGB - Fix a bunch of bugs #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improve the name of first parameter to `rgb_assign_color()` to reflect it's a bitmask of which LEDs to assign the color to. * Formatting changes to more easily compare similar code.
* Each `T_CONFIG_...` option is listed on its own line. This improves the ability to diff changes. It also allows reading the options in code editor. (no ultra-long lines!) * Align the elmeents of of `sub_prompts[]`. This allows easier understanding of the differences between each array element. * Use named initializers for `main_cfg` and `main_prompt` variables. This simply adds clarity when reviewing the code.
No behavioral change. Just makes it harder to make mistakes later. Static assertions added for the same reason.
Rewrote function for setting brightness from menu for increased clarity. Fix LED config name to reflect its purpose: Specifically, it doesn't store the LED brightness, but rather stores a divisor value (i.e., the inverse of storing the brightness). Store the LED effect as an enum. (self-documenting, better debugger visualizations, ...) Delete some dead code.
Eventually, will have this use the user's chosen color. Importantly, it uses higher brightness for edge pixels than for those facing same direction as the screen.
DangerousPrototypes
merged commit 6d383ad
into
DangerousPrototypes:main
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights:
uint32_t.There's also a number of bugfixes, off-by-one adjustments, formatting updates, and more comments documenting the code's intended behavior.