RGB: Using 2D mappings for effects (+QoL changes) #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need for handling both RGB and GRB (or other pixel-specific color ordering). Updates are all internal to `rgb.c`. * Rename `CPIXEL_COLOR_RGB` --> `CPIXEL_COLOR` * Delete `CPIXEL_COLOR_GRB` * Remove corresponding C11 _Generic() macros * Remove `RGB_MAX_BRIGHT`
Add mappings for both Rev10 and Rev8 boards: * coordinates map the pixels into a 256x256 grid * angles map the pixels into an angle based on 1/256th-of-a-circle units
Not enabled yet, but commented-out as replacements for scanner effect
Add same self-documenting comments to `pixel_angle256` as are provided for `pixel_coordin8`.
|
Although this does not include any gamma correction, I think this can be merged. |
|
So sorry! I didn't see this changed from draft. |
DangerousPrototypes
merged commit a7bb193
into
DangerousPrototypes:main
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.