Holidays are only recognized at 00:00

[schwarmco]

A holiday should be recognized on the whole day.
The example snippet const nowIsHoliday = moment().isHoliday() in the README suggests, that this is also meant to be in the feature scope.

Example Code:

const moment = require('moment-feiertage')

console.log(moment('2020-12-25 17:00').isHoliday()) // false
console.log(moment('2020-12-25 00:00').isHoliday()) // 1. Weihnachtsfeiertag

A possible fix would probably be, to change

moment-feiertage/src/index.ts

Line 110 in 5f86fe5

if (_moment.isSame(holidays[h].date)) {

to

if (_moment.isSame(holidays[h].date, 'day')) { 

[DaniSchenk]

Damn! That's critical. Thank you for reporting back. I provided a fix and updated tests. Missed that in my Typescript rewrite...