Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle windows paths from Linux #37

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

AkhilTThomas
Copy link

I have a use case where i run the a2ltool from a WSL2 but the A2L contains windows style paths.
This PR handles this scenario.
Example:
/include "Config\McData\Xcp.a2l" cannot be evaluated in WSL2 / Linux

@DanielT
Copy link
Owner

DanielT commented Nov 20, 2024

This is a good improvement.
One minor point: could you please add a test for this code? I'm trying to improve the test quality and test coverage over time, so preferably all new features should also have tests.

@AkhilTThomas
Copy link
Author

This is a good improvement. One minor point: could you please add a test for this code? I'm trying to improve the test quality and test coverage over time, so preferably all new features should also have tests.

I have added test cases for linux paths in windows and windows paths in linux.

@DanielT
Copy link
Owner

DanielT commented Nov 20, 2024

Thanks!

@DanielT DanielT merged commit 3259aba into DanielT:main Nov 20, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants