Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide raw data without modifying values like Country code, Currency etc. #6

Open
Lakshman1996 opened this issue Jun 28, 2021 · 3 comments

Comments

@Lakshman1996
Copy link
Contributor

Hi

52 - Merchant Category Code
53 - Transaction Currency"
58 - Country Code

The decoded data for above ids contains extra value which is added to data for example: LK (Sri Lanka) for 58.
If there is a an options object that decode method can take and return raw data that would be awesome

I am willing to submit a PR as well

Thanks

@DannielWhatever
Copy link
Owner

Hi, I just accepted your pull request, I will upload a version with your changes to npmjs, as soon as I have a little time I will review the issues. thanks for your contribution ;)

@Lakshman1996
Copy link
Contributor Author

The PR that I have submitted was for a different fix. However ill try to fix this when I get some free time.

Nice library BTW!

@DannielWhatever
Copy link
Owner

DannielWhatever commented Jul 10, 2021

Oops, you are right! I just made a general refactor and push a new alpha version, this one emvqr@1.0.0-alpha.0 . With these changes I include the rawData field in every emvItem. I hope this will be useful for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants