Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to compute last byte checksum (for Dallas 1990 format) #15

Open
eblis opened this issue Oct 12, 2024 · 2 comments
Open

Add ability to compute last byte checksum (for Dallas 1990 format) #15

eblis opened this issue Oct 12, 2024 · 2 comments

Comments

@eblis
Copy link
Contributor

eblis commented Oct 12, 2024

I'm not sure about all formats, but it looks as though the Dallas iButton protocol uses the last byte as a checksum and it should be computed using the first 7 bytes of the UID.

Could you please modify the iButton fuzzer so it doesn't add bogus data for the last byte (at least for Dallas protocol) and instead compute the last byte by using the values of the first 7 bytes.

If you try to manually add a Dallas 1990 key in Flipper and you edit any of the first 7 bytes you can see the last (rightmost) byte change value every time you change any of the other bits, seems to be a checksum of sorts.

I think the fuzzer should only mess with the first 7 bytes and automatically compute the last one.

@eblis
Copy link
Contributor Author

eblis commented Oct 12, 2024

Also, the first byte should also always be 01.

@eblis
Copy link
Contributor Author

eblis commented Oct 12, 2024

I think this is a method of computing the CRC https://github.com/PaulStoffregen/OneWire/blob/master/OneWire.cpp#L537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant