From 83756f011e6239ce778b98a0e4c5de9d44b42056 Mon Sep 17 00:00:00 2001 From: Wedson Almeida Filho Date: Tue, 25 Apr 2023 15:56:04 +0200 Subject: [PATCH] rust: sync: add `Arc::{from_raw, into_raw}` These methods can be used to turn an `Arc` into a raw pointer and back, in a way that preserves the metadata for fat pointers. This is done using the unstable ptr_metadata feature [1]. However, it could also be done using the unstable pointer_byte_offsets feature [2], which is likely to have a shorter path to stabilization than ptr_metadata. Link: https://github.com/rust-lang/rust/issues/81513 [1] Link: https://github.com/rust-lang/rust/issues/96283 [2] Signed-off-by: Wedson Almeida Filho Co-developed-by: Alice Ryhl Signed-off-by: Alice Ryhl Reviewed-by: Martin Rodriguez Reboredo --- rust/kernel/lib.rs | 1 + rust/kernel/sync/arc.rs | 44 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 45 insertions(+) diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs index cdf9fe99932843..82854c86e65d51 100644 --- a/rust/kernel/lib.rs +++ b/rust/kernel/lib.rs @@ -22,6 +22,7 @@ #![feature(generic_associated_types)] #![feature(new_uninit)] #![feature(pin_macro)] +#![feature(ptr_metadata)] #![feature(receiver_trait)] #![feature(unsize)] diff --git a/rust/kernel/sync/arc.rs b/rust/kernel/sync/arc.rs index e6d20624246529..7c55a9178dfb5e 100644 --- a/rust/kernel/sync/arc.rs +++ b/rust/kernel/sync/arc.rs @@ -210,6 +210,50 @@ impl Arc { } } + /// Convert the [`Arc`] into a raw pointer. + /// + /// The raw pointer has ownership of the refcount that this Arc object owned. + pub fn into_raw(self) -> *const T { + let ptr = self.ptr.as_ptr(); + core::mem::forget(self); + // SAFETY: The pointer is valid. + unsafe { core::ptr::addr_of!((*ptr).data) } + } + + /// Recreates an [`Arc`] instance previously deconstructed via [`Arc::into_raw`]. + /// + /// This code relies on the `repr(C)` layout of structs as described in + /// . + /// + /// # Safety + /// + /// `ptr` must have been returned by a previous call to [`Arc::into_raw`]. Additionally, it + /// can only be called once for each previous call to [`Arc::into_raw`]. + pub unsafe fn from_raw(ptr: *const T) -> Self { + // SAFETY: The safety requirement ensures that the pointer is valid. + let val_align = core::mem::align_of_val(unsafe { &*ptr }); + let refcount_size = core::mem::size_of::>(); + + // Use the `repr(C)` algorithm to compute the offset of `data` in `ArcInner`. + // + // Pseudo-code for the `#[repr(C)]` algorithm can be found here: + // + let mut val_offset = refcount_size; + let val_misalign = val_offset % val_align; + if val_misalign > 0 { + val_offset += val_align - val_misalign; + } + + // This preserves the metadata in the pointer, if any. + let metadata = core::ptr::metadata(ptr as *const ArcInner); + let ptr = (ptr as *mut u8).wrapping_sub(val_offset) as *mut (); + let ptr = core::ptr::from_raw_parts_mut(ptr, metadata); + + // SAFETY: By the safety requirements we know that `ptr` came from `Arc::into_raw`, so the + // reference count held then will be owned by the new `Arc` object. + unsafe { Self::from_inner(NonNull::new_unchecked(ptr)) } + } + /// Returns an [`ArcBorrow`] from the given [`Arc`]. /// /// This is useful when the argument of a function call is an [`ArcBorrow`] (e.g., in a method