Skip to content
This repository has been archived by the owner on Apr 29, 2020. It is now read-only.

Sanitize user input during the login flow. #6368

Open
mrhappyasthma opened this issue Jan 12, 2020 · 1 comment
Open

Sanitize user input during the login flow. #6368

mrhappyasthma opened this issue Jan 12, 2020 · 1 comment

Comments

@mrhappyasthma
Copy link
Contributor

The current code doesn't really do any checking at all. We should enforce username and password length limits, restrict their characters (e.g. exclude spaces), and protect against malicious inputs (e.g. trying to manipulate the SQL query based on their input.)

@TeoTwawki
Copy link
Member

the connect server does prevent injection attacks (in a not very optimal way) but the loader still lets you pass anything you want atm. the connect server then decides wtf to do with it without any feedback to the user - so we should edit the loader to have some sort of error when an invalid account name is given.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants