Skip to content
This repository has been archived by the owner on Apr 29, 2020. It is now read-only.

Remove unused attack type breath enum. #6411

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove unused attack type breath enum. #6411

wants to merge 1 commit into from

Conversation

mrhappyasthma
Copy link
Contributor

This enum value is unused.

Breath spells seem to just be classified as magical with the appropriate element.

Removing this should alleviate some ambiguity/confusion when trying to use the appropriate value.

(Found this during an audit of BLU spells for #6225)

This enum value is unused.

Breath spells seem to just be classified as  `magical` with the appropriate element.

Removing this should alleviate some ambiguity/confusion when trying to use the appropriate value.
@TeoTwawki
Copy link
Member

might possibly have been done with the intent to use it during implementation of how breaths actually should work (based on current/max hp) and just never got done.

https://www.bg-wiki.com/bg/Damage_Taken#Breath_Damage_Taken
oddly MDT doesn't effect it unless it was from an augment. possibly SE's guy adding augments didn't realize, or SE has an unfixed bug.
https://www.ffxiah.com/forum/topic/52145/finally-releasing-this-addon-gearinfo/8/#3344204

@mrhappyasthma
Copy link
Contributor Author

Would you prefer to leave this value? And, if so, should it be used for BLU breath spells instead of MAGICAL?

Whatever we decide I can implement it as part of the clean ups.

@TeoTwawki
Copy link
Member

Nothing stopping us from re-adding it if its actually needed later I spoze, but I'm not decision making either way here. I don't even know if that is needed to implement it, just thought I'd give the score on breath damage.

@mrhappyasthma
Copy link
Contributor Author

Understood.

I'll leave this PR open then for now.

During my audit I'll continue with the existing convention of annotating breath BLU spells as MAGICAL. We can always correct them whenever we add appropriate breath spell handling.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants